evaluting 3 statements in while loop condition

[rix]

this is probly the easiest thing u've been asked today if u know java . .

I have this statement

while ((userInput!='1')&&(userInput!='2')&&(userInput!='3')){

System.out.println("That was not a valid entry");
	 	userInput=in.readCharacter();
		}

the idea is if the user doesnt enter 1,2 or 3 the program will loop til they do. This works okay but each time the program prints the error 3 times. How can aviod this please ?

[joyous monkey]

Try using the OR operand instead of the AND... it seems that the WHILE condition is being satisfied THREE times in your predetermined condition.

[rix]

Thats right, i think for each '!=' it prints the line, i tried with 2 conditions and it prints only 2 lines.

With OR it does not work at all, i think i will have to change the structure of the statement but i dont know how . .

[Sappe]

You can try this:

boolean x = false;
while ( x== false ) {
userinput=in.readCharacter();
if ( userinput == 0 || userinput > 3 ) {
System.out.println("That was not a valid entry");
}
else {boolean=true;}
}

[rix]

yes, ill have to use some sort of boolean test, thanks for idea.

[cjard]

Originally posted by rix

I have this statement

while ((userInput!='1')&&(userInput!='2')&&(userInput!='3')){

if the user doesnt enter 1,2 or 3 the program will loop til they do. [/B]

the solution is inherent in the statement you just made.. you say "1 or 2 or 3", and then you are using the AND operator in java.. you want an OR

this code works:

char userInput = '0';
while ((userInput!='1')||(userInput!='2')||(userInput!='3')){
  System.out.print("Please enter 1, 2 or 3:");
  userInput=in.readCharacter();
}

[rix]

thanks but the or doesn't work. in the end i just rewrote the code