Queue Class

[Inzaghi]

Hi,

I would like to develop a StringQueue class to hold a queue of String objects.
I am not exactly sure how I would go about doing this.

I have created a StringList class which looks something like this:

public class StringList
{
    // attributes
    private String[] list;
    private int total;
    
    // methods
    public StringList (int sizeIn)
    {  
        list = new String [sizeIn];
        total = 0;
    }


    public boolean add(String s)
    {   
        if(!isFull())
        {
            list[total] = s;
            total++;
            return true;
        }
        else
        {
            return false;
        }
    }
    
    public boolean isEmpty(
    {
        if(total==0)
        {
            return true;
        }
        else
        {
            return false;
        }
    }
    
    public boolean isFull()
    {
        if(total==list.length)
        {
            return true;
        }
        else
        {
            return false;
        }
    }
    
    public String getItem (int i)
    {
        return list [i-1];
    }
    
    public int getTotal()
    {
        return total;
    }
    
    public boolean remove (int numberIn)
    {
        // to be completed
    }
}

Any suggestion would be appreciated

Thanks

[sjalle]

public class StringList
{
    // attributes
    private String[] list;
    private int total;
    
    // methods
    public StringList (int sizeIn)
    {  
        list = new String [sizeIn];
     }


    public boolean add(String s)
    {   
        if(!isFull())
        {
            list[total++] = s;
            return true;
        }
        else
        {
            return false;
        }
    }
    
    public boolean isEmpty(
    {
       return total==0;
     }
    
    public boolean isFull()
    {
        return total==list.length;
    }
    // this is very 'off-by-one'-error prone, you should go for
    // zero-based indexing.   
    public String getItem (int i)
    {
        return list [i-1];
    }
    
    public int getTotal()
    {
        return total;
    }
    
    public boolean remove (int numberIn)
    {
        // to be completed
    }
}

[Inzaghi]

Thanks for your improvements i will do that.

What would i have to change in the code to create a StringQueue class?

Thanks

[sjalle]

A queue would need code for shifting all its elements to the next 'slot'. The best
would then be a linked list consisting of elements like:

public class ListElement {
  public ListElement previous;
  public Object value;
  public ListElement next;
}

[Inzaghi]

thanks

[meisl]

java.util.LinkedList<String>