need suggestion about "new JRadioButton"

[efm]

hello,
i'm new in java, and i need suggestion about things below:

which is better:

to use

private void try {
  radiobutton1.setSelected(true);
  radiobutton2.setSelected(false);
  radiobutton3.setSelected(false);
}

or this one:

private void setSelectedRadioButtons(JRadioButton[] rb, boolean[] b) {
  for (int i=0; i<=rb.length; i++) {
    rb[i].setSelected(b[i]);
  }
}

private void try {
  setSelectedRadioButtons( 
    new JRadioButton[] { radiobutton1, radiobutton2, radiobutton3 },
    new boolean[] { true, false, false }
  }
}

currently, i'm using the latter in my program, but i'm afraid that it takes lots of memory or
it's a "not suggested" line of code.

if the latter is ok, then i will use it for other components and properties

thank you

[piratepops]

The idea of the latter is better, because it is more reusable...it would support any number of items, rather than just 3, which you would have to recode for another program that needs more than three items. However, I don't think you should name a method 'try', as that is a Java keyword used in exception handling. Not necessarily an error, but it's bad practice.

[major]

Does this code compile for you, i dont see a ) to close the method.

private void try {
setSelectedRadioButtons(
new JRadioButton[] { radiobutton1, radiobutton2, radiobutton3 },
new boolean[] { true, false, false }
}
}

[efm]

hi all,

major: i have a typo there, you're rite, it should be a ")", not a "}"

pirate: thanks for the suggestion, so it's ok if i use the second lines of code? will i get memory lack or
something? because i don't really understand of the keyword "new" is. isn't it to make a new instance?

and about that "try" keyword hehe, i wrote it myself, not copy pasting it from my code. so it's a
mistake.

thank you

[piratepops]

pirate: thanks for the suggestion, so it's ok if i use the second lines of code? will i get memory lack or
something? because i don't really understand of the keyword "new" is. isn't it to make a new instance?

It should be fine, you don't have to worry so much about the memory leaks in Java, because Java has automated memory management, unlike some other OOP languages. Any values you've set up in RAM will be cleaned out by the garbage collector a few milliseconds or so after no reference variables are pointing to them. The new operator is typically used to make an instance, such as:

Foo f = new Foo();
myMethod(f);


but, you can also use it to create objects on the fly without a variable, the way you are doing it with your code, such as;

myMethod(new Foo);