Out of memory error

[nickiii]

Hi all:

I creating a data range control to be used on several pages in my site. It gives me an out of memory error when entering the do/while loop but I can't figure out why. Does anything jump out at you guys?

private void Page_Load(object sender, System.EventArgs e)
{            
            SqlConnection cnn = new SqlConnection(ConfigurationManager.AppSettings["CnnString"]);
            SqlCommand myCommand;
            SqlDataReader myReader;
            ArrayList dateTimeList;
            DateTime dtBegin;
            DateTime dtEnd;
            
            if (!IsPostBack)
            {
                dtBegin = Convert.ToDateTime(string.Format("{0:MM/dd/yyyy}", "10/1/2005"));
                cnn.Open();
                myCommand = new SqlCommand();
                myCommand.Connection = cnn;
                myCommand.CommandType = CommandType.StoredProcedure;
                myCommand.CommandText = "usp_GetDate";

                dateTimeList = new ArrayList();

                myReader = myCommand.ExecuteReader();

                if (myReader.HasRows)
                {
                    myReader.Read();
                    dtEnd = Convert.ToDateTime(myReader[0]);

                }
               
                    do
                    {
                        dateTimeList.Add(string.Format("{0:MM/dd/yyyy}", dtBegin)); 
                        dtBegin = DateAdd(DateInterval.Day, 1, dtBegin); 
                    }
                    while (!(dtEnd < dtBegin));
                
                  dateTimeList.Reverse(); 
            
                  ddlBeginDate.DataSource = dateTimeList; 
                  ddlBeginDate.DataBind(); 
            
                  ddlEndDate.DataSource = dateTimeList; 
                  ddlEndDate.DataBind();
              }
             
                myReader.Close();
                myCommand.Dispose();
                cnn.Close();
                cnn.Dispose();
         }
}

[Hack]

Are the end and begin dates valid?

[nickiii]

Are the end and begin dates valid?

To my knowledge. I used a Response.Write to print both dates out and they look fine.

begin = 10/1/2005 12:00:00 AM
end = 2/12/2008 12:00:00 AM

[Hack]

Does it immediately get the out of memory error or does it churn for a while first?

[nickiii]

It churns for a long while before the error appears. For a while, it locked my machine up. So, I added a try/catch and now it errors out immediately. I'm about to step thru the code and see what I can gather.

[Hack]

I'm about to step thru the code and see what I can gather.

That was going to be my next question (have you?)

You should be able to pinpoint where it is going off into the ether.

[nickiii]

Problem is it's not incrementing the days as it goes through the loop. Guess I need to use something other than "AddDays()".

[nickiii]

Oh silly me. It should be

 dtBegin = dtBegin.AddDays(1);

Instead of

 dtBegin.AddDays(1);

Problem resolved.

Thanks Hack!

[Hack]

My pleasure.

Anytime I can do virtually nothing for you, just let me know.