Reading a matrix (txt) to a matrix (c)

[Codeblue]

Last week i put on air my very very simple doubt (i think it should be that way!!!).
So, i'm trying to copy a matrix of integers (0 and 1s) in text format (matrix.txt) to a matrix (bidimensional array on C++).
Can anyone give me some suggestions please


regards

[emanresu]

from a matrix integers to a matrix of what?
do you want to dump the matrix into a file in binary format??

not sure what you are trying to achieve here.

if you just want to read the integers from the txt file into a C++ program, it should be easy.

[Codeblue]

I would like to create a matrix in C++ with data from the text matrix. Something with the type matrix[i][j].

thanx

[emanresu]

if this is the case, then let us assume that your text file contains only those numbers, and they are separated by space. so it would look something like

1 2 3 4 4
2 3 4 5 5
5 5 5 5 5


the code to read it is

int x[3][5];
ifstream infile;
infile.open("mymatrix.txt");

for (int i = 0; i < 3; i++) {
   for (int j = 0; j < 5; j++) {
      infile>>x[i][j];
   }
}

[Codeblue]

I followed your suggestion and my programme comes like this:

(see attach prog.doc)

However as you can see some problems have occured.

Í must tell that i'm using Microsoft Visual C++.
Can it be that those errors come from the libraries i'm using? Should i open some others?

Many thanx again.

[gorshing]

I'm not a big fan of mixing C I/O functions (scanf, printf) and C++ I/O functions (iostream, fstream) ... but that is personal preference.

Other than that, remove the space between the # and the include. It should be #include, not # include.

[emanresu]

if you are using Visual C++ .NET, you also need to include

using namespace std;

right after all your includes.

another problem is that your input to the program are not used. they are supposed to indicate the rows and columns of the matrix, however, in your for loops, you have hard-coded the size to be 3x5. you need to replace them with lines and cols.

[emanresu]

one more thing. your code will still not compile, because you were attempting to do a dynamical array, sort of, but in an incorrect way.

in C++, you cannot let the user input size of the array and then create it on the fly. you can only use constants like

int matrix[3][5];

or

#define ROW 3
#define COL 5

int matrix[ROW][COL];

but you cannot use variables.

if you want to create dynamic array, you must use pointers which is a little more complicated.

[Codeblue]

First i have to thanks emanresu and gorshing for your suggestions.
Following some desperation as i think every day i understand less of C i have tried other way and, for the some kind of aim i built the following progr (with dynamic arrays). Once again probs occorred. What might be the errors?

#include <stdio.h>

void main()
{
int col, row, i, j;
int **arr;
FILE *fin;
fin=fopen("test.txt","r");
printf("number of cols:\n");
scanf("%d\n\n",&col);
printf("number of rows:\n");
scanf("%d\n\n",&row);
arr=new int*[row];
for(i=0;i<row;i++)
{
arr[i]=new int[col];
for(j=0;j<col,j+)
{
fscanf(fin,"%d \n,&arr[i][j]);
}
}
fclose(fin);
printf("%d \n",arr[1][1]);
}


Compiling...
test.c
C: \MyProjects\test\test.c(13) : error C2065: 'new' : undeclared identifier
C:\ MyProjects\test\test.c(13) : warning C4047: '=' : 'int ** ' differs in levels of indirection from 'int '
C:\ MyProjects\test\test.c(13) : error C2143: syntax error : missing ';' before 'type'
C:\ MyProjects\test\test.c(16) : warning C4047: '=' : 'int *' differs in levels of indirection from 'int '
C:\MyProjects\test\test.c(16) : error C2143: syntax error : missing ';' before 'type'
C:\ MyProjects\test\test.c(17) : error C2059: syntax error : ')'
C:\ MyProjects\test\test.c(19) : error C2001: newline in constant
C:\ MyProjects\test\test.c(25) : fatal error C1004: unexpected end of file found
Error executing cl.exe.

test.exe - 6 error(s), 2 warning(s)

[emanresu]

new is what you use in C++ to define dynamic arrays, but not in C.

in C++, you must use malloc() + sizeof()... so it will be like this


arr = malloc(sizeof(int*) * row );

for (int i=0; i <row; i++) {

arr[i] = (malloc(sizeof(int) * col);
}

[Codeblue]

i have to thank u emanresu again by your encouraging explanations.
They really worked!!!!!!!!!!!

I'm afraid a day ahead i should come back with pretty more silly doubts.

best regards

[emanresu]

no problem, codeblue. anytime.