problem sending binary file in a socket

[ebooserge]

hi everybody,
first sorry for my english i'm french :)
i'm trying to build an http server in c++ and i have some problems.
for simple html pages (no picture, no effects, no javascript), no problem. my server send pages and firefox (or IE) shows it normally.
but when i put a background picture on this html page, the navigator send me 2 requests:
- fisrt to ask me the page.
- second to ask me the picture.
no problem for the first request.
for the second request, i open the picture with the standard fonction fopen(url, "rb").
then i put the content of the file in a buffer with fread(buffer,1,sizeof(picture), fic)
next i declare a second buffer called response which will content http headers and the first buffer.
my http header:

HHTP/1.1 200 OK\n
Accept-Ranges: bytes\n
Content-Length: taille\n
Content-Type: image/jpeg\n\n

next:
strcpy(response, httpHeader);
strcat(response, contentOfBuffer);
int sentBytes = send(socket,response,sizeof(reponse),0);

when i'm testing, sentBytes = sizeof(reponse).
that means the server had all sent to the navigator but this one shows binary characters instead of pictures.
can someone help me ?
thank you for your replies and sorry again for my english.

[jonnin]

do not use strcat. It is for C strings and stops when a zero (0) is encountered in the binary stream. Use memcpy -- it will not stop until size is reached.

for example
int i = 0;
while (string_thing[i++]); //find end of string.
memcpy(&(string_thing[i+1]), pic, size_of_pic_file);

you should know the size when you read it from file, use that instead of trying to make sizeof work. you will be happier.

[Danny]

never sizeof in this context -- the string's size is dynamic, and is determined by the number of bytes before the first '\0'. Sizeof isn't aware of this and besides, it's value is calcuclated at compiler time, probably as the size of the *pointer* (i.e. 4 bytes) rather than the array's length.